change signature of signed_by to accept &impl AsRef<CertificateParams> issuer #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djc
approved these changes
Jan 4, 2025
djc
reviewed
Jan 4, 2025
|
This seems like a nice improvement! |
|
The issue with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had the issue that I wanted to use an issuer that was a
CertificateParams, not aCertificate(because CertificateParams can be deserialized from file, but Certificate can not). The best solution I've found is to change the signature to accept&impl AsRef<CertificateParams>, and then implement thatAsReffor bothCertificateandCertificateParams.I think this is also a backwards-compatible change, but I'm not 100% sure.